add test for fix containsHeader test when it is not instance of Respo…

…nse, Issue #5977 was partially fixed

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>

jetty-servlet/src/test/java/org/eclipse/jetty/servlet/CacheControlHeaderTest.java

@@ -29,6 +29,7 @@
 import javax.servlet.ServletRequest;
 import javax.servlet.ServletResponse;
 import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpServletResponseWrapper;
 
 import org.eclipse.jetty.http.HttpHeader;
 import org.eclipse.jetty.server.HttpConfiguration;
@@ -46,19 +47,37 @@ public class CacheControlHeaderTest
     private Server server;
     private LocalConnector connector;
 
+    public static class SimpleResponseWrapper extends HttpServletResponseWrapper
+    {
+        public SimpleResponseWrapper(HttpServletResponse response)
+        {
+            super(response);
+        }
+    }
+
     public static class ForceCacheControlFilter implements Filter
     {
+        private boolean forceWrapper;
+
         @Override
         public void init(FilterConfig filterConfig) throws ServletException
         {
+            forceWrapper = Boolean.parseBoolean(filterConfig.getInitParameter("FORCE_WRAPPER"));
         }
 
         @Override
         public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException
         {
             HttpServletResponse httpResponse = (HttpServletResponse)response;
             httpResponse.setHeader(HttpHeader.CACHE_CONTROL.asString(), "max-age=0,private");
-            chain.doFilter(request, response);
+            if (forceWrapper)
+            {
+                chain.doFilter(request, new SimpleResponseWrapper((HttpServletResponse)response));
+            }
+            else
+            {
+                chain.doFilter(request, response);
+            }
         }
 
         @Override
@@ -67,7 +86,7 @@ public void destroy()
         }
     }
 
-    public void startServer(boolean forceFilter) throws Exception
+    public void startServer(boolean forceFilter, boolean forceWrapping) throws Exception
     {
         server = new Server();
 
@@ -84,7 +103,8 @@ public void startServer(boolean forceFilter) throws Exception
         context.addServlet(servletHolder, "/*");
         if (forceFilter)
         {
-            context.addFilter(ForceCacheControlFilter.class, "/*", EnumSet.of(DispatcherType.REQUEST));
+            FilterHolder filterHolder = context.addFilter(ForceCacheControlFilter.class, "/*", EnumSet.of(DispatcherType.REQUEST));
+            filterHolder.setInitParameter("FORCE_WRAPPER", Boolean.toString(forceWrapping));
         }
         server.setHandler(context);
         server.addConnector(connector);
@@ -105,7 +125,7 @@ public void testCacheControlFilterOverride() throws Exception
     {
         try
         {
-            startServer(true);
+            startServer(true, false);
             StringBuffer req1 = new StringBuffer();
             req1.append("GET /content.txt HTTP/1.1\r\n");
             req1.append("Host: local\r\n");
@@ -127,12 +147,39 @@ public void testCacheControlFilterOverride() throws Exception
         }
     }
 
+    @Test
+    public void testCacheControlFilterOverrideWithWrapper() throws Exception
+    {
+        try
+        {
+            startServer(true, true);
+            StringBuffer req1 = new StringBuffer();
+            req1.append("GET /content.txt HTTP/1.1\r\n");
+            req1.append("Host: local\r\n");
+            req1.append("Accept: */*\r\n");
+            req1.append("Connection: close\r\n");
+            req1.append("\r\n");
+
+            String response = connector.getResponse(req1.toString());
+            assertThat("Response status",
+                       response,
+                       containsString("HTTP/1.1 200 OK"));
+            assertThat("Response headers",
+                       response,
+                       containsString(HttpHeader.CACHE_CONTROL.asString() + ": max-age=0,private"));
+        }
+        finally
+        {
+            stopServer();
+        }
+    }
+
     @Test
     public void testCacheControlDefaultServlet() throws Exception
     {
         try
         {
-            startServer(false);
+            startServer(false, false);
             StringBuffer req1 = new StringBuffer();
             req1.append("GET /content.txt HTTP/1.1\r\n");
             req1.append("Host: local\r\n");