Merge pull request #6698 from eclipse/jetty-10.0.x-6696-WebSocketUpgr…

…adeRequest Issue #6696 - don't keep Request object in the WebSocketNegotiation after upgrade
jetty · Sep 8, 2021 · aa75d04 · aa75d04
2 parents 6023e13 + 2aa966a
commit aa75d04
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...re-server/src/main/java/org/eclipse/jetty/websocket/core/server/WebSocketNegotiation.java b/...re-server/src/main/java/org/eclipse/jetty/websocket/core/server/WebSocketNegotiation.java
@@ -31,10 +31,10 @@
 
 public abstract class WebSocketNegotiation
 {
-    private final Request baseRequest;
     private final HttpServletRequest request;
     private final HttpServletResponse response;
     private final WebSocketComponents components;
+    private Request baseRequest;
     private String version;
     private List<ExtensionConfig> offeredExtensions;
     private List<ExtensionConfig> negotiatedExtensions;
@@ -54,6 +54,11 @@ public Request getBaseRequest()
         return baseRequest;
     }
 
+    public void upgrade()
+    {
+        this.baseRequest = null;
+    }
+
     public HttpServletRequest getRequest()
     {
         return request;

diff --git a/...er/src/main/java/org/eclipse/jetty/websocket/core/server/internal/AbstractHandshaker.java b/...er/src/main/java/org/eclipse/jetty/websocket/core/server/internal/AbstractHandshaker.java
@@ -167,6 +167,7 @@ public boolean upgradeRequest(WebSocketNegotiator negotiator, HttpServletRequest
         // Save state from request/response and remove reference to the base request/response.
         upgradeRequest.upgrade();
         upgradeResponse.upgrade();
+        negotiation.upgrade();
 
         if (LOG.isDebugEnabled())
             LOG.debug("upgrade connection={} session={} framehandler={}", connection, coreSession, handler);