Issue #5684 Fix testSetBadBoolean and remove @disabled (#5875)

Signed-off-by: Jan Bartel <janb@webtide.com>
jetty · Jan 12, 2021 · a5a8327 · a5a8327
1 parent 03ec5bb
commit a5a8327
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/jetty-xml/src/test/java/org/eclipse/jetty/xml/XmlConfigurationTest.java b/jetty-xml/src/test/java/org/eclipse/jetty/xml/XmlConfigurationTest.java
@@ -1046,16 +1046,17 @@ public void testSetBooleanFalse() throws Exception
     }
 
     @Test
-    @Disabled
     public void testSetBadBoolean() throws Exception
     {
         XmlConfiguration xmlConfiguration = asXmlConfiguration(
             "<Configure class=\"org.eclipse.jetty.xml.XmlConfigurationTest$NativeHolder\">" +
                 "  <Set name=\"boolean\">tru</Set>" +
                 "</Configure>");
 
+        //Any string other than "true" (case insensitive) will be false
+        //according to Boolean constructor.
         NativeHolder bh = (NativeHolder)xmlConfiguration.configure();
-        assertTrue(bh.getBoolean(), "boolean['tru']");
+        assertFalse(bh.getBoolean(), "boolean['tru']");
     }
 
     @Test