Merge pull request #5109 from eclipse/jetty-9.4.x-5108-SessionTracker…

…Scalability Issue #5108 - improve scalability of WebSocket SessionTrackers
jetty · Aug 4, 2020 · 8af767f · 8af767f
2 parents 344cdf5 + 85c4fc5
commit 8af767f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/...ocket-client-impl/src/main/java/org/eclipse/jetty/websocket/jsr356/JsrSessionTracker.java b/...ocket-client-impl/src/main/java/org/eclipse/jetty/websocket/jsr356/JsrSessionTracker.java
@@ -19,19 +19,21 @@
 package org.eclipse.jetty.websocket.jsr356;
 
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.Set;
-import java.util.concurrent.CopyOnWriteArraySet;
+import java.util.concurrent.ConcurrentHashMap;
+import javax.websocket.Session;
 
 import org.eclipse.jetty.util.component.AbstractLifeCycle;
 import org.eclipse.jetty.util.component.LifeCycle;
 
 public class JsrSessionTracker extends AbstractLifeCycle implements JsrSessionListener
 {
-    private CopyOnWriteArraySet<JsrSession> sessions = new CopyOnWriteArraySet<>();
+    private final Set<JsrSession> sessions = Collections.newSetFromMap(new ConcurrentHashMap<>());
 
-    public Set<javax.websocket.Session> getSessions()
+    public Set<Session> getSessions()
     {
-        return Collections.unmodifiableSet(sessions);
+        return Collections.unmodifiableSet(new HashSet<>(sessions));
     }
 
     @Override
@@ -49,7 +51,7 @@ public void onSessionClosed(JsrSession session)
     @Override
     protected void doStop() throws Exception
     {
-        for (JsrSession session : sessions)
+        for (Session session : sessions)
         {
             LifeCycle.stop(session);
         }

diff --git a/...ket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/SessionTracker.java b/...ket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/SessionTracker.java
@@ -20,20 +20,21 @@
 
 import java.io.IOException;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.Set;
-import java.util.concurrent.CopyOnWriteArraySet;
+import java.util.concurrent.ConcurrentHashMap;
 
 import org.eclipse.jetty.util.component.AbstractLifeCycle;
 import org.eclipse.jetty.util.component.Dumpable;
 import org.eclipse.jetty.util.component.LifeCycle;
 
 public class SessionTracker extends AbstractLifeCycle implements WebSocketSessionListener, Dumpable
 {
-    private CopyOnWriteArraySet<WebSocketSession> sessions = new CopyOnWriteArraySet<>();
+    private final Set<WebSocketSession> sessions = Collections.newSetFromMap(new ConcurrentHashMap<>());
 
     public Set<WebSocketSession> getSessions()
     {
-        return Collections.unmodifiableSet(sessions);
+        return Collections.unmodifiableSet(new HashSet<>(sessions));
     }
 
     @Override