Issue #4331 Close Complete

Set _onError in onWriteComplete NOOP callback instead of null Signed-off-by: Greg Wilkins <gregw@webtide.com>
jetty · Dec 10, 2019 · 8553f41 · 8553f41
1 parent 589b71a
commit 8553f41
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/HttpOutput.java b/jetty-server/src/main/java/org/eclipse/jetty/server/HttpOutput.java
@@ -286,10 +286,17 @@ void onWriteComplete(boolean last, Throwable failure)
 
                 case PENDING:
                     _apiState = ApiState.ASYNC;
+                    if (failure != null)
+                    {
+                        _onError = failure;
+                        wake = _channel.getState().onWritePossible();
+                    }
                     break;
 
                 case UNREADY:
                     _apiState = ApiState.READY;
+                    if (failure != null)
+                        _onError = failure;
                     wake = _channel.getState().onWritePossible();
                     break;
 
@@ -1345,7 +1352,7 @@ public void run()
             finally
             {
                 // Initiate an async close
-                close(null);
+                close(Callback.NOOP);
             }
         }
     }