Issue #4483 - More resiliency on bad DNS servers

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
jetty · Jan 16, 2020 · 782c099 · 782c099
1 parent b25a587
commit 782c099
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/jetty-util/src/test/java/org/eclipse/jetty/util/InetAddressSetTest.java b/jetty-util/src/test/java/org/eclipse/jetty/util/InetAddressSetTest.java
@@ -122,14 +122,13 @@ public void testBadSingleton(final String badAddr)
             InetAddress inetAddress = InetAddress.getByName(badAddr);
             Assumptions.assumeTrue(inetAddress == null);
         }
-        catch (UnknownHostException ignored)
+        catch (UnknownHostException expected)
         {
+            //noinspection MismatchedQueryAndUpdateOfCollection
+            InetAddressSet inetAddressSet = new InetAddressSet();
+            IllegalArgumentException cause = assertThrows(IllegalArgumentException.class, () -> inetAddressSet.add(badAddr));
+            assertThat(cause.getMessage(), containsString(badAddr));
         }
-
-        //noinspection MismatchedQueryAndUpdateOfCollection
-        InetAddressSet inetAddressSet = new InetAddressSet();
-        IllegalArgumentException cause = assertThrows(IllegalArgumentException.class, () -> inetAddressSet.add(badAddr));
-        assertThat(cause.getMessage(), containsString(badAddr));
     }
 
     @Test