#4855 fix race condition that can sometimes make H2 stream send an i…

…mproper reset with cancel error code instead of protocol error code when the client sends more data than the content-length header specifies Signed-off-by: Ludovic Orban <lorban@bitronix.be>
jetty · Jun 9, 2020 · 714a920 · 714a920
1 parent 56bda1b
commit 714a920
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Stream.java b/jetty-http2/http2-common/src/main/java/org/eclipse/jetty/http2/HTTP2Stream.java
@@ -320,7 +320,7 @@ private void onData(DataFrame frame, Callback callback)
         if (dataLength != Long.MIN_VALUE)
         {
             dataLength -= frame.remaining();
-            if (frame.isEndStream() && dataLength != 0)
+            if (dataLength < 0 || (frame.isEndStream() && dataLength != 0))
             {
                 reset(new ResetFrame(streamId, ErrorCode.PROTOCOL_ERROR.code), Callback.NOOP);
                 callback.failed(new IOException("invalid_data_length"));