Issue #6974 - fix bug in ByteBufferPool implementations

If an allocation size of 0 was requested bucketFor would throw. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
jetty · Dec 3, 2021 · 6fd2213 · 6fd2213
1 parent d55a917
commit 6fd2213
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java b/jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java
@@ -202,7 +202,7 @@ protected void releaseMemory(boolean direct)
 
     protected int bucketFor(int capacity)
     {
-        return (int)Math.ceil((double)capacity / getCapacityFactor());
+        return Math.max((int)Math.ceil((double)capacity / getCapacityFactor()), 1);
     }
 
     protected int capacityFor(int bucket)

diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/MappedByteBufferPool.java b/jetty-io/src/main/java/org/eclipse/jetty/io/MappedByteBufferPool.java
@@ -181,7 +181,7 @@ protected void releaseMemory(boolean direct)
         }
         if (index >= 0)
         {
-            Bucket bucket = buckets.get(index);
+            Bucket bucket = buckets.remove(index);
             // Null guard in case this.clear() is called concurrently.
             if (bucket != null)
                 bucket.clear();
@@ -190,7 +190,7 @@ protected void releaseMemory(boolean direct)
 
     protected int bucketFor(int capacity)
     {
-        return (int)Math.ceil((double)capacity / getCapacityFactor());
+        return Math.max((int)Math.ceil((double)capacity / getCapacityFactor()), 1);
     }
 
     protected int capacityFor(int bucket)