#6379: requeue at the tail to reduce contention + use a simpler conc…

…urrent queue implementation Signed-off-by: Ludovic Orban <lorban@bitronix.be>
jetty · Jun 9, 2021 · 5d41093 · 5d41093
1 parent 5c130e4
commit 5d41093
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferPool.java b/jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferPool.java
@@ -20,9 +20,9 @@
 
 import java.nio.ByteBuffer;
 import java.util.ArrayList;
-import java.util.Deque;
 import java.util.List;
-import java.util.concurrent.ConcurrentLinkedDeque;
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.function.Consumer;
@@ -154,7 +154,7 @@ public void release(ByteBuffer buffer)
 
     class Bucket
     {
-        private final Deque<ByteBuffer> _queue = new ConcurrentLinkedDeque<>();
+        private final Queue<ByteBuffer> _queue = new ConcurrentLinkedQueue<>();
         private final ByteBufferPool _pool;
         private final int _capacity;
         private final int _maxSize;
@@ -232,7 +232,7 @@ void clear(Consumer<ByteBuffer> memoryFn)
 
         private void queueOffer(ByteBuffer buffer)
         {
-            _queue.offerFirst(buffer);
+            _queue.offer(buffer);
         }
 
         private ByteBuffer queuePoll()