Issue #1771 - changes from review

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
jetty · May 17, 2022 · 0663261 · 0663261
1 parent 2d0af90
commit 0663261
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/jetty-server/src/main/config/etc/jetty-secure-redirect.xml b/jetty-server/src/main/config/etc/jetty-secure-redirect.xml
@@ -2,20 +2,10 @@
 <!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "https://www.eclipse.org/jetty/configure_10_0.dtd">
 
 <Configure id="Server" class="org.eclipse.jetty.server.Server">
-  <Get id="Handler" name="handler"/>
-  <Call name="setHandler">
+  <Call name="insertHandler">
     <Arg>
-      <New class="org.eclipse.jetty.server.handler.HandlerList">
-        <Call name="addHandler">
-          <Arg>
-            <New id="SecuredRedirectHandler" class="org.eclipse.jetty.server.handler.SecuredRedirectHandler">
-              <Arg type="int"><Property name="jetty.redirect.code" default="302"/></Arg>
-            </New>
-          </Arg>
-        </Call>
-        <Call name="addHandler">
-          <Arg><Ref refid="Handler"/></Arg>
-        </Call>
+      <New id="SecuredRedirectHandler" class="org.eclipse.jetty.server.handler.SecuredRedirectHandler">
+        <Arg type="int"><Property name="jetty.secureredirect.code" default="302"/></Arg>
       </New>
     </Arg>
   </Call>

diff --git a/jetty-server/src/main/config/etc/jetty.xml b/jetty-server/src/main/config/etc/jetty.xml
@@ -60,7 +60,7 @@
     <!-- =========================================================== -->
     <New id="httpConfig" class="org.eclipse.jetty.server.HttpConfiguration">
       <Set name="secureScheme" property="jetty.httpConfig.secureScheme"/>
-      <Set name="securePort"><Property name="jetty.httpConfig.securePort" default="8443"/></Set>
+      <Set name="securePort" property="jetty.httpConfig.securePort"/>
       <Set name="outputBufferSize" property="jetty.httpConfig.outputBufferSize"/>
       <Set name="outputAggregationSize" property="jetty.httpConfig.outputAggregationSize"/>
       <Set name="requestHeaderSize" property="jetty.httpConfig.requestHeaderSize"/>

diff --git a/jetty-server/src/main/config/modules/secure-redirect.mod b/jetty-server/src/main/config/modules/secure-redirect.mod
@@ -14,4 +14,4 @@ etc/jetty-secure-redirect.xml
 
 [ini-template]
 ## The redirect code to use in the response.
-# jetty.redirect.code=302
+# jetty.secureredirect.code=302