Issue #5539 - Deprecating 'xml' request parameter in StatisticsServlet

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
jetty · Nov 16, 2020 · 02f35de · 02f35de
1 parent 5362467
commit 02f35de
Showing 1 changed file with 6 additions and 14 deletions.
diff --git a/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java b/jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java
@@ -118,6 +118,11 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
             return;
         }
 
+        if (request.getParameter("xml") != null)
+        {
+            LOG.warn("'xml' parameter is deprecated, use 'Accept' request header instead");
+        }
+
         List<String> acceptable = getOrderedAcceptableMimeTypes(request);
 
         for (String mimeType : acceptable)
@@ -134,21 +139,8 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
                     writeHtmlResponse(response);
                     return;
                 case "text/plain":
-                    writeTextResponse(response);
-                    return;
                 case "*/*":
-                    String wantXml = request.getParameter("xml");
-                    if (wantXml == null)
-                        wantXml = request.getParameter("XML");
-
-                    if (Boolean.parseBoolean(wantXml))
-                    {
-                        writeXmlResponse(response);
-                    }
-                    else
-                    {
-                        writeTextResponse(response);
-                    }
+                    writeTextResponse(response);
                     return;
                 default:
                     if (LOG.isDebugEnabled())