Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing cast expressions. #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow parsing cast expressions. #33

wants to merge 3 commits into from

Conversation

reitermarkus
Copy link

@reitermarkus reitermarkus commented Sep 8, 2022 •
edited

Revival of #15.

@reitermarkus reitermarkus force-pushed the cast-expr branch 3 times, most recently from 458ae2e to 5354667 Compare September 8, 2022 22:03
@reitermarkus reitermarkus mentioned this pull request Sep 9, 2022
Closed
emilio
emilio reviewed Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance it looks reasonable, but I'm confused about the patch section, can you clarify whether you intend that to be merged?

Cargo.toml
clang = { version = "2", features = ["runtime"] }

[patch.crates-io]
clang-sys = { git = "https://github.com/reitermarkus/clang-sys", branch = "load-api" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upstream or remove this? It seems unfortunate not depending on the crates.io version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An upstream PR is already opened. This is only needed for the last commit in this PR, cleaning up the test setup.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to split the test setup cleanup into its own PR? Seems like there's some push back against making the change to clang-sys since it's a breaking change...

@dpaoliello
Copy link

@emilio @reitermarkus Would either of you be opposed to creating a fork of this PR minus the dependency on the new clang-sys and associated test changes?

@reitermarkus
Copy link
Author

@dpaoliello, I have given up on cexpr since it is way too limited. I have written a replacement (cmacro-rs) which supports much more complex macros.

Sadly no one has reviewed my PR at rust-lang/rust-bindgen#2369 replacing cexpr with cmacro yet. Would love to get some feedback on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio left review comments

@dpaoliello dpaoliello dpaoliello left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @dpaoliello @emilio