Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ms support and better docs for leeway #54

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Added ms support and better docs for leeway #54

merged 3 commits into from
Jan 23, 2023

Conversation

rawnly
Copy link
Contributor

@rawnly rawnly commented Jan 23, 2023

@rawnly
Copy link
Contributor Author

rawnly commented Jan 23, 2023

You might don't want to use canary version of ms, but as said there: vercel/ms#184 is going to be released as stable soon and has it own types

@rawnly
Copy link
Contributor Author

rawnly commented Jan 23, 2023

Just noticed a bug! The output of ms is in milliseconds but the tokenExpireFudge was expected in seconds :)

@rawnly rawnly requested a review from revmischa January 23, 2023 21:03
@revmischa revmischa merged commit 14d6abc into jetbridge:master Jan 23, 2023
@rawnly rawnly deleted the feat/ms branch January 24, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revmischa revmischa revmischa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rawnly @revmischa