Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to have length guard #9796

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Fix to have length guard #9796

merged 2 commits into from
Apr 11, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Apr 11, 2020

Summary

If it isn't broke, don't fix it.

I reverted back to the original guard since the type hasn't changed and it was an ugly nest of conditions.

Test plan

Added a new test case.


fixes #9792

@G-Rath
Copy link
Contributor Author

G-Rath commented Apr 11, 2020

@SimenB @nfantone sorry again - I've reverted the check and added a test for the future.

@codecov-io
Copy link

Codecov Report

Merging #9796 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9796   +/-   ##
=======================================
  Coverage   64.87%   64.87%           
=======================================
  Files         288      288           
  Lines       12206    12206           
  Branches     3023     3025    +2     
=======================================
  Hits         7919     7919           
  Misses       3646     3646           
  Partials      641      641           
Impacted Files Coverage Δ
packages/expect/src/matchers.ts 96.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff87b43...dcb561b. Read the comment docs.

@SimenB SimenB merged commit 317c413 into jestjs:master Apr 11, 2020
@SimenB
Copy link
Member

SimenB commented Apr 11, 2020

Thanks! 😃

sit added a commit to sit/Pinano-Discord-Bot that referenced this pull request Apr 12, 2020
Run `npm update`.

Manually bump jest version. There are some security updates to try
and apply. Somewhere recently jest broke `toHaveLength` which
will be fixed in next release (see jestjs/jest#9796), so update
test to check length directly.
@nfantone
Copy link

Thanks indeed!

@G-Rath G-Rath deleted the fix-toHaveLength-guard branch April 16, 2020 13:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing arity of functions no longer works
5 participants