Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST IGNORE ME - Attempt to fix pipelines #9269

Closed
wants to merge 15 commits into from
Closed

TEST IGNORE ME - Attempt to fix pipelines #9269

wants to merge 15 commits into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Dec 5, 2019

This is me attempting to find out what's going on w/ #8829, as the pipeline is failing silently after the tests seem to pass :(

I'm opening a new PR b/c I want to strip out code, and don't want github to mark comments as resolved or outdated.

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #9269 into master will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9269      +/-   ##
==========================================
+ Coverage   64.99%   64.99%   +<.01%     
==========================================
  Files         278      278              
  Lines       11912    11913       +1     
  Branches     2934     2935       +1     
==========================================
+ Hits         7742     7743       +1     
  Misses       3539     3539              
  Partials      631      631
Impacted Files Coverage Δ
...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts 0% <0%> (ø) ⬆️
packages/jest-jasmine2/src/setup_jest_globals.ts 0% <0%> (ø) ⬆️
packages/jest-snapshot/src/snapshot_resolver.ts 96.66% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446d174...2c0bc75. Read the comment docs.

@G-Rath
Copy link
Contributor Author

G-Rath commented Jan 17, 2020

So it seems that the failures are caused by adding anything in the e2e/transform folder?

The src code passes if I commit it without the e2e changes, and I can add a new test to e2e/__test__/transform.test.ts, but if I add even a stray snapshot file at e2e/transform/transform-snapshotResolver/__snapshots__/add.test.js.snap CI fails with "yarn exited with error code 1".

While interesting (and hopefully useful), I'm not sure where to go from here - I could write some hacky scripts or try to patch-package yarn to dump more info, but I'd be pretty much making blind stabs.

@SimenB @jeysal - would either of you have any insights on possible next steps?

@SimenB
Copy link
Member

SimenB commented Jan 20, 2020

to me it looks like you haven't committed the test file, so it's an obsolete snapshot?

essentially rickhanlonii/jest-silent-reporter#15 (and somewhat rickhanlonii/jest-silent-reporter#8)

@SimenB
Copy link
Member

SimenB commented Jan 20, 2020

yup:
image

@G-Rath
Copy link
Contributor Author

G-Rath commented Jan 20, 2020

Huh ok interesting - I tried to check things out with the default reporter on the there branch but didn't see any snapshot messages, but hopefully I've just missed them.

I'll push up the rest of the stuff and see if it still fails.

Maybe the snapshot is always obsolete, and that's what's causing the failure...

(I've got a feeling that's the case, and that I've messed up my own snapshot resolver 😬)

@G-Rath G-Rath closed this Apr 3, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants