Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace FlowType with Typescript in CONTRIBUTING.MD code conventions #9133

Merged
merged 2 commits into from
Nov 5, 2019
Merged

docs: replace FlowType with Typescript in CONTRIBUTING.MD code conventions #9133

merged 2 commits into from
Nov 5, 2019

Conversation

leonardovillela
Copy link
Contributor

Summary

It now seems that Flow Type is no longer the default option. #7554

Test plan

N/A

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #9133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9133   +/-   ##
=======================================
  Coverage   64.77%   64.77%           
=======================================
  Files         277      277           
  Lines       11722    11722           
  Branches     2878     2878           
=======================================
  Hits         7593     7593           
  Misses       3512     3512           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ece746...1e45252. Read the comment docs.

Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
@SimenB SimenB merged commit e3f4c65 into jestjs:master Nov 5, 2019
@leonardovillela leonardovillela deleted the update-contributing-md branch November 5, 2019 13:54
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants