Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --passWithNoTests message to match exit code #8193

Closed
wants to merge 1 commit into from
Closed

Change --passWithNoTests message to match exit code #8193

wants to merge 1 commit into from

Conversation

j33n
Copy link

@j33n j33n commented Mar 22, 2019

Summary

Fixes #8187

Test plan

$ y jest blahblah --passWithNoTests
yarn run v1.15.0
$ node ./packages/jest-cli/bin/jest.js blahblah --passWithNoTests
No tests found, exiting with code 0
In /Users/jeanabayo/Side/oss/jest
  2156 files checked across 14 projects. Run with `--verbose` for more details.
Pattern: blahblah - 0 matches
✨  Done in 1.36s.

@codecov-io
Copy link

Codecov Report

Merging #8193 into master will decrease coverage by 0.02%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8193      +/-   ##
==========================================
- Coverage    62.3%   62.28%   -0.03%     
==========================================
  Files         265      265              
  Lines       10473    10478       +5     
  Branches     2542     2543       +1     
==========================================
+ Hits         6525     6526       +1     
- Misses       3366     3369       +3     
- Partials      582      583       +1
Impacted Files Coverage Δ
packages/jest-core/src/getNoTestFoundVerbose.ts 0% <0%> (ø) ⬆️
packages/jest-core/src/getNoTestFound.ts 40% <33.33%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4e170...3858345. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

Could you add a test for this? And please update the changelog 🙂

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also append "with code 0 because of --passWithNoTests". If the flag is hidden somewhere in the package.json scripts, people might not realize it's in use

@SimenB
Copy link
Member

SimenB commented Jun 24, 2019

#8595

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading message for passWithNoTests.
5 participants