Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro for #7493 #8015

Closed
wants to merge 1 commit into from
Closed

repro for #7493 #8015

wants to merge 1 commit into from

Conversation

itajaja
Copy link

@itajaja itajaja commented Mar 1, 2019

this is a reproduction for #7493. as you can see, there are 4 snapshots generated, and that's not the expected behavior. it's not a failing test per se, but I just wanted to share the issue real quick, I can work on a more robust failing test later

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@thymikee
Copy link
Collaborator

FYI this is being worked on here: #8015

@itajaja
Copy link
Author

itajaja commented Mar 18, 2019

you are referencing this issue itself. you probably meant #8019

@thymikee
Copy link
Collaborator

Yup, thanks!

@itajaja
Copy link
Author

itajaja commented Mar 18, 2019

thanks for looking into this!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants