Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opaque symlink support #7549

Closed
wants to merge 4 commits into from
Closed

feat: opaque symlink support #7549

wants to merge 4 commits into from

Commits on Jun 1, 2020

  1. feat: opaque symlink support 

    Every "node_modules" directory within a project root is searched for linked dependencies.

Each linked dependency can become a project root if its resolved path meets these criteria:
  - not inside a "node_modules" directory
  - not inside an existing project root

Once all linked dependencies are found, collect every file (including symlinks) in each of the project roots.

Two properties are added to the cache of "jest-haste-map":
  "links": Map of link paths (relative to rootDir) to their metadata
  "roots": Array of configured roots and linked roots

One method is added to the "HasteFS" class:
  "follow": Lazily resolves any symlink found by the crawler

鈿狅笍  The JS crawler does *not* yet support symlinks; only the Watchman crawler does.

鈿狅笍  Watch mode does *not* yet support symlinks.
    @aleclarson
    aleclarson committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    984d6be View commit details
    Browse the repository at this point in the history

  2. fix: dependency links not being saved in cache

    @aleclarson
    aleclarson committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    b821a19 View commit details
    Browse the repository at this point in the history

  3. fix: use relative path as key in "links" map

    @aleclarson
    aleclarson committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    58384db View commit details
    Browse the repository at this point in the history

  4. fix: forgot to make the target relative

    @aleclarson
    aleclarson committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    377ecb3 View commit details
    Browse the repository at this point in the history