Move unnecessary dependencies to devDependencies for babel plugins
#15010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
liuxingbaoyu
changed the title
dependencies to devDependencies for babel-plugin-jest-hoistdependencies to devDependencies for babel plugin
liuxingbaoyu
changed the title
dependencies to devDependencies for babel plugindependencies to devDependencies for babel plugins
|
I thought these endes up in our public types, but maybe that has changed? |
|
You're right! I should look for another solution, especially with babel/babel#16416. |
|
Yeah https://www.runpkg.com/?babel-plugin-jest-hoist@29.6.3/build/index.d.ts Seems we can remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found it at babel/babel#16413 and although I've added the solution in Babel, it looks like removing them in Jest is fine.
Test plan
CI green