Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce %$ option to add number of the test to its title #14710

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kemuridama
Copy link

Summary

%# option to add index of the test to its title has been introduced by #6414. Similarly to it, I want to add number of the test to its title.

This PR proposes to add %$ option to add number of the test to its title.

I don't know that %$ is suitable as a placeholder. So I'd appreciate it if you could consider that point.

Test plan

Tests have been added.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b4e3267
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6600da4a10a5530008384fd3
😎 Deploy Preview https://deploy-preview-14710--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linux-foundation-easycla bot commented Nov 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@SimenB
Copy link
Member

SimenB commented Dec 25, 2023

@mattphillips thoughts? I like the feature, but I'm also unsure about using $

Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 24, 2024
@github-actions github-actions bot removed the Stale label Mar 25, 2024
@SimenB SimenB added the Pinned label Mar 26, 2024
@SimenB SimenB added this to the Jest 30 milestone Mar 26, 2024
@SimenB
Copy link
Member

SimenB commented Mar 26, 2024

@mattphillips would love your input here 😀 I'm inclined to land it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants