Stop issue from #444 causing randomly failing runs #14682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for jestjs failed.Built without sensitive environment variables
|
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Yep, praying for some review or feedback… |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Please review or give some feedback - this is not stale, this blocks us from upgrading because we cannot patch jest any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a recreation of my original PR: #11104
(sorry - it was ignored for a year, then got 2 review comments and then ignored for another year. I've tried mentioning, requesting review and asking for help on the forum). I'm hoping I can get some traction on this now, since our work-around, where we (and many other users) patch jest with every install is getting more difficult in jest v30 with the bundling.
Summary
We would like to not have jest failing multiple runs a day because of #4444.
See #4444 (comment) for an explanation of what is going on.
essentially "reasonably sure" in the comment means 99% of the time, but not 100% of the time, meaning jest fails some of the time, which is not great.
Test plan
This is really hard to test... If you think this is an approach you could accept I'd be happy to discuss what else you need.
I don't mind removing the console.log if you like or making this opt-in e.g. "makeJestWorkForLargeCodebasesOnWindows" or whatever you want me to do,, please tell me, I just want to stop having to patch jest and be allowed to update to v30.