Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-runtime): expose isTornDown variable #13698

Closed
wants to merge 0 commits into from

Conversation

jomendez
Copy link
Contributor

This commit adds a new feature to the Jest runtime package that exposes the isTornDown variable as a way to check if the Jest environment has been torn down programmatically. The isTornDown variable is a read-only boolean that is set to true when the environment is torn down and false otherwise.

The commit also adds documentation for the isTornDown variable to the Jest runtime module.

Closes #13640

Summary

The motivation for exposing the isTornDown variable in the Jest runtime package is to provide a way for tests to check if the Jest environment has been torn down programmatically.
issue #13640 requesting this feature.

Test plan

Test Objective

The objective of this test is to verify that the isTornDown variable is correctly exposed in the Jest runtime package and that it can be used to check if the Jest environment has been torn down programmatically.

Test Steps

  1. Clone the Jest repository and make sure that the isTornDown feature has been implemented and is ready for testing.
  2. Create a new test file that imports the jest global object and uses the isTornDown variable to check if the Jest environment has been torn down.
  3. Run the test file using the jest command.
  4. Verify that the test file runs successfully and that the isTornDown variable is correctly set to false when the Jest environment is not torn down.
  5. Modify the test file to tear down the Jest environment after the test has run.
  6. Run the test file again using the jest command.
  7. Verify that the test file runs successfully and that the isTornDown variable is correctly set to true when the Jest environment has been torn down.
  8. Modify the test file to check the isTornDown variable in a loop that advances the fake timers by a specified amount of time.
  9. Run the test file again using the jest command and verify that the test file stops executing when the Jest environment is torn down.
  10. Modify the test file to check the isTornDown variable in a loop that does a lot of work and can time out.
  11. Run the test file with a long timeout value (e.g. --timeout=10000) and verify that the test file stops executing when the Jest environment is torn down or the test times out.

Test Expected Results

  • The test file should run successfully and the isTornDown variable should be correctly set to false when the Jest environment is - not torn down.
  • The test file should run successfully and the isTornDown variable should be correctly set to true when the Jest environment is torn down.
  • The test file should stop executing when the Jest environment is torn down or the test times out.

@facebook-github-bot
Copy link
Contributor

Hi @jomendez!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

* return;
* }
*/
isTornDown: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be a function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs seems to be missing? also, please add a test and a changelog entry

@mrazauskas
Copy link
Contributor

Perhaps it is worth to name it jest.isEnvironmentTornDown() instead? See discussion in #13640

@SimenB
Copy link
Member

SimenB commented Dec 31, 2022

Yeah, that sounds reasonable. Or even "is test completed"?

@jomendez
Copy link
Contributor Author

jomendez commented Jan 7, 2023

I messed up on this PR, not sure how it got closed and all the commits diapers, anyways, I created a new PR addressing all the comments here #13741

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: expose isTornDown readonly property
4 participants