Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): make writefile path compatible posix and windows system #13270

Merged
merged 4 commits into from Sep 17, 2022
Merged

chore(build): make writefile path compatible posix and windows system #13270

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59db7e6
fix: make writefile path compatible posix and windows system
weidehai Sep 16, 2022
43b7aea
Update scripts/bundleTs.mjs
SimenB Sep 16, 2022
8963bc2
fix lint error scripts/bundleTs.mjs
weidehai Sep 17, 2022
26bc01a
diff
SimenB Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/bundleTs.mjs
View file
Open in desktop
Expand Up @@ -200,8 +200,10 @@ const excludedPackages = new Set(['@jest/globals']);
filepath,
});

const {sep} = path;
const replaceDirReg = new RegExp(`(?<=\\${sep})(dist)(?=\\${sep})`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB you'll need to remove this line too

Suggested change
const {sep} = path;
const replaceDirReg = new RegExp(`(?<=\\${sep})(dist)(?=\\${sep})`);
const {sep} = path;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes，i remove it😊

await fs.promises.writeFile(
filepath.replace('/dist/', '/build/'),
filepath.replace(`${sep}dist${sep}`, `${sep}build${sep}`),
formattedContent,
);
}),
Expand Down