Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @babel/core #13245

Merged
merged 3 commits into from Sep 14, 2022
Merged

chore: update @babel/core #13245

merged 3 commits into from Sep 14, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 10, 2022

Summary

This for some reason loses a stack trace in https://github.com/facebook/jest/blob/27b46b65aa8c5e8ecb1608ec1aa426b771e600e2/e2e/__tests__/jest.config.ts.test.ts

I'm not certain this is bad per se, but it's a surprising change.

@nicolo-ribaudo thoughts? I assume it's from babel/babel#11554

Test plan

Update the snapshot? 馃槄

@nicolo-ribaudo
Copy link
Contributor

Babel should only hide its own stack frames; this looks like a bug.

@SimenB
Copy link
Member Author

SimenB commented Sep 12, 2022

@nicolo-ribaudo See #13248 for a slightly less convoluted reproduction.

Should I open up an issue in the Babel repo?

@SimenB SimenB linked an issue Sep 14, 2022 that may be closed by this pull request
@SimenB SimenB merged commit e703e6e into jestjs:main Sep 14, 2022
@SimenB SimenB deleted the update-babel-core branch September 14, 2022 17:25
robhogan added a commit to robhogan/metro that referenced this pull request Oct 18, 2022
Summary:
Following on from D39543504 (facebook@69607ae) and D40379963, this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template.

Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment.

[General] [Changed] - Upgrade Jest in React Native template to ^29.2.1

Differential Revision: D40386349

fbshipit-source-id: f324df6b80cff474cd357a37ce50b832375abeac
robhogan added a commit to robhogan/react-native that referenced this pull request Oct 18, 2022
Summary:
X-link: facebook/metro#881

Following on from D39543504 (facebook@c27501b) and D40379963 (facebook@8f33753), this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template.

Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment.

[General] [Changed] - Upgrade Jest in React Native template to ^29.2.1

Differential Revision: D40386349

fbshipit-source-id: 524a6f19008abcd5b0dad02ef2c3f1c39d10cc29
facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Oct 19, 2022
Summary:
X-link: facebook/react-native#35014

Pull Request resolved: #881

Following on from facebook/react-native#34724 and facebook/react-native#34972, this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template.

Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment.

Changelog:
[General] [Changed] - Upgrade Jest in React Native template to ^29.2.1

Reviewed By: jacdebug

Differential Revision: D40386349

fbshipit-source-id: 43f5a69cf546df09e2f02542ebf50130d65f0436
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Oct 19, 2022
Summary:
Pull Request resolved: #35014

X-link: facebook/metro#881

Following on from #34724 and #34972, this updates Jest to the latest version 29.2.1 across projects and in the OSS React Native new app template.

Importantly this version includes the [new `jest.now()` API](jestjs/jest#13245), which will be useful for exposing internally consistent fake timer mocks of `requestAnimationFrame`, etc., in the new React Native Jest environment.

Changelog:
[General] [Changed] - Upgrade Jest in React Native template to ^29.2.1

Reviewed By: jacdebug

Differential Revision: D40386349

fbshipit-source-id: 43f5a69cf546df09e2f02542ebf50130d65f0436
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Module Import Stack Trace sometimes broken
3 participants