Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:-Simplified the Jest-haste-map API #13237

Closed
wants to merge 13 commits into from
Closed

Fix:-Simplified the Jest-haste-map API #13237

wants to merge 13 commits into from

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Sep 9, 2022

Tried scratching The Jest-haste-map api and seems like the majority of it is unused and also no mention in docs too, we can simplify the api further which is what this PR is done for

@robhogan
Copy link
Contributor

robhogan commented Sep 9, 2022

Great minds.. ;) #13023

@Smrtnyk
Copy link

Smrtnyk commented Sep 10, 2022

its funny how both PRs look identical, indeed great minds think the same

@Biki-das
Copy link
Contributor Author

hey @Smrtnyk could you help me with the lint issues!

@Biki-das
Copy link
Contributor Author

@SimenB could you provide some direction with the duplicate import error, could not figure out something that can work!

@Biki-das Biki-das changed the title Fix:-Simplied the Jest-haste-map API Fix:-Simplified the Jest-haste-map API Sep 10, 2022
@@ -10,6 +10,7 @@ import * as path from 'path';
import * as fs from 'graceful-fs';
import {sync as resolveSync} from 'resolve';
import {ModuleMap} from 'jest-haste-map';
Copy link

@Smrtnyk Smrtnyk Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe import { type IModuleMap, ModuleMap} from 'jest-haste-map';
I am not very familiar with eslint rules in jest repo @Biki-das but maybe it follows the above convention

@SimenB
Copy link
Member

SimenB commented Sep 10, 2022

Yeah, let's land #13023 👍

@SimenB SimenB closed this Sep 10, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants