Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jest-runtime): avoid star type import from @jest/globals #12949

Merged
merged 2 commits into from Jun 20, 2022
Merged

fix(jest-runtime): avoid star type import from @jest/globals #12949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2227391
refactor(jest-runtime): rework type imports
mrazauskas Jun 17, 2022
73b5f19
add changelog entry
mrazauskas Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -4,6 +4,8 @@

### Fixes

-`[jest-runtime]` Avoid star type import from `@jest/globals` ([#12949](https://github.com/facebook/jest/pull/12949))

### Chore & Maintenance

- `[docs]` Mention that jest-codemods now supports Sinon ([#12898](https://github.com/facebook/jest/pull/12898))
Expand Down
8 changes: 4 additions & 4 deletions packages/jest-runtime/src/index.ts
View file
Open in desktop
Expand Up @@ -32,7 +32,7 @@ import type {
ModuleWrapper,
} from '@jest/environment';
import type {LegacyFakeTimers, ModernFakeTimers} from '@jest/fake-timers';
import type * as JestGlobals from '@jest/globals';
import type {expect, jest} from '@jest/globals';
import type {SourceMapRegistry} from '@jest/source-map';
import type {
RuntimeTransformResult,
Expand Down Expand Up @@ -69,11 +69,11 @@ const dataURIRegex =
/^data:(?<mime>text\/javascript|application\/json|application\/wasm)(?:;(?<encoding>charset=utf-8|base64))?,(?<code>.*)$/;

interface JestGlobals extends Global.TestFrameworkGlobals {
expect: typeof JestGlobals.expect;
expect: typeof expect;
}

interface JestGlobalsWithJest extends JestGlobals {
jest: typeof JestGlobals.jest;
jest: typeof jest;
}

type HasteMapOptions = {
Expand Down Expand Up @@ -2331,7 +2331,7 @@ export default class Runtime {
beforeAll: this._environment.global.beforeAll,
beforeEach: this._environment.global.beforeEach,
describe: this._environment.global.describe,
expect: this._environment.global.expect as any,
expect: this._environment.global.expect as typeof expect,
fdescribe: this._environment.global.fdescribe,
fit: this._environment.global.fit,
it: this._environment.global.it,
Expand Down