Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn when setting testSequencer as project config #12864

Conversation

jkklapp
Copy link

@jkklapp jkklapp commented May 20, 2022

Summary

Throw error if testSequencer options is used in a per-project config. Should close #9761

Test plan

N/A

@jkklapp jkklapp force-pushed the chore/throw-error-on-test-sequencer-project-config branch from 283de8f to 89ce0b4 Compare May 20, 2022 13:28
@jkklapp jkklapp changed the title chore: throw error when setting testSequencer as project config chore: warn when setting testSequencer as project config May 20, 2022
@jkklapp jkklapp force-pushed the chore/throw-error-on-test-sequencer-project-config branch 4 times, most recently from 3bb09c6 to f1431c2 Compare May 20, 2022 15:10
@jkklapp jkklapp force-pushed the chore/throw-error-on-test-sequencer-project-config branch from f1431c2 to be406d7 Compare May 20, 2022 15:15
@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Aug 18, 2022
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry for the late review.

This isn't the correct fix - we should only check if it's explicitly within projects - having it at the top level like the test you tweaked is perfectly fine.

https://github.com/facebook/jest/blob/7d8d01c4854aa83e82cc11cefdd084a7d9b8bdfc/e2e/custom-esm-test-sequencer/package.json#L3-L7

@github-actions github-actions bot removed the Stale label Aug 19, 2022
@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 17, 2022
@SimenB
Copy link
Member

SimenB commented Nov 17, 2022

#13565 did this more generically

@SimenB SimenB closed this Nov 17, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSequencer config silently ignored in projects
3 participants