Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update babel #12780

Merged
merged 1 commit into from Apr 30, 2022
Merged

chore: update babel #12780

merged 1 commit into from Apr 30, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 30, 2022

Summary

From babel/babel#14497

/cc @nicolo-ribaudo

Test plan

Tweaked tests

sourcesContent: ['content'],
mappings:
Copy link
Member Author

@SimenB SimenB Apr 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order of keys has changed, but AAeY is also now IAeY. just to verify @jridgewell, that's a correct change?

(same change in all the tests, fwiw)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand source maps, but the reason is probably babel/babel#14506

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds likely 😀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A (0) -> I (4) in the first VLQ field likely means we've skipped 4 space chars used for indentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@SimenB SimenB merged commit 49393d0 into jestjs:main Apr 30, 2022
@SimenB SimenB deleted the bump-babel branch April 30, 2022 16:01
F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants