Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): add missing 'slash' dependency #12078

Closed

Conversation

joshuakimDwan
Copy link

@joshuakimDwan joshuakimDwan commented Nov 19, 2021

Summary

I updated my jest library to latest(27.3.1) and ran test. The following error occured:

Error: jest-config tried to access slash, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: slash
Required by: jest-config@virtual:1bcce2f81654c62ba2c1f43389ad4059fbcc03a8875db1c4310173c058b718cab0f288f5cb8b498bea4c346752a90efbfc010d5498d6be71854ef8949f11199a#npm:27.3.1 (via /[my-directory]/.yarn/__virtual__/jest-config-virtual-d3c1205189/0/cache/jest-config-npm-27.3.1-8c4eee5f7f-1a86b03456.zip/node_modules/jest-config/build/)

I was trying to find the cause of this problem. The cause was that the code using 'slash' was committed last month (#11922) but the 'slash' dependency was not added to package.json.

So I solved this problem by adding the missing dependency.

@joshuakimDwan joshuakimDwan changed the title fix(jest-config): add missing slash dependency fix(jest-config): add missing 'slash' dependency Nov 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #12078 (86dbdda) into main (7bb400c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12078   +/-   ##
=======================================
  Coverage   68.88%   68.89%           
=======================================
  Files         324      324           
  Lines       16669    16669           
  Branches     4814     4814           
=======================================
+ Hits        11483    11484    +1     
+ Misses       5153     5152    -1     
  Partials       33       33           
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.37% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb400c...86dbdda. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Nov 26, 2021

Thanks for the PR! Unfortunately I missed it and merged #12080 instead. Sorry about that!

@SimenB SimenB closed this Nov 26, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants