Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-haste-map): Add computeDependencies to cache path #11916

Merged
merged 1 commit into from Sep 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -6,6 +6,7 @@

- `[@jest/types]` Mark deprecated configuration options as `@deprecated` ([#11913](https://github.com/facebook/jest/pull/11913))
- `[jest-cli]` Improve `--help` printout by removing defunct `--browser` option ([#11914](https://github.com/facebook/jest/pull/11914))
- `[jest-haste-map]` Use distinct cache paths for different values of `computeDependencies` ([#11916](https://github.com/facebook/jest/pull/11916))

### Chore & Maintenance

Expand Down
14 changes: 14 additions & 0 deletions packages/jest-haste-map/src/__tests__/index.test.js
Expand Up @@ -265,6 +265,20 @@ describe('HasteMap', () => {
expect(hasteMap1.getCacheFilePath()).not.toBe(hasteMap2.getCacheFilePath());
});

it('creates different cache file paths for different values of computeDependencies', () => {
jest.resetModules();
const HasteMap = require('../').default;
const hasteMap1 = new HasteMap({
...defaultConfig,
computeDependencies: true,
});
const hasteMap2 = new HasteMap({
...defaultConfig,
computeDependencies: false,
});
expect(hasteMap1.getCacheFilePath()).not.toBe(hasteMap2.getCacheFilePath());
});

it('creates different cache file paths for different hasteImplModulePath cache keys', () => {
jest.resetModules();
const HasteMap = require('../').default;
Expand Down
1 change: 1 addition & 0 deletions packages/jest-haste-map/src/index.ts
Expand Up @@ -325,6 +325,7 @@ export default class HasteMap extends EventEmitter {
(options.ignorePattern || '').toString(),
hasteImplHash,
dependencyExtractorHash,
this._options.computeDependencies.toString(),
);
this._buildPromise = null;
this._watchers = [];
Expand Down