Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(expect): add exports to satisfy playwright #11816

Closed
wants to merge 7 commits into from
Closed

chore(expect): add exports to satisfy playwright #11816

wants to merge 7 commits into from

Commits on Sep 5, 2021

  1. Add exports to satisfy playwright 

    The `playwright` repo uses `expect`, I'd like to bump the version they're using from `26.4.2` to `27.1.0`. Here is the issue which motivated this change: jestjs#11640

You can see my proposed changes here:
microsoft/playwright@master...mrienstra:patch-3

I haven't opened a PR for those changes yet, hoping to land this one first.

Playwright `npm check-deps` runs `utils/check_deps.js`, which contains a function `allowExternalImport` / `alllowExternalImport` (very recently added in microsoft/playwright#8501), which has a problem with the `expect` `package.json` `exports`, thus the motivation for this PR.
    @mrienstra
    mrienstra committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    5e87d84 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Merge branch 'facebook:master' into patch-1

    @mrienstra
    mrienstra committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    2afdb1b View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Merge branch 'facebook:main' into patch-1

    @mrienstra
    mrienstra committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9a103e2 View commit details
    Browse the repository at this point in the history

  2. chore: revert changes to exports in package.json

    @mrienstra
    mrienstra committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    236586a View commit details
    Browse the repository at this point in the history

  3. chore(expect): add matchers to main expect export (expect.matchers) (… 

    …matchers from src/matchers)
    @mrienstra
    mrienstra committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    65912a8 View commit details
    Browse the repository at this point in the history

  4. chore(expect): add 2 print utils to main expect export (expect.print)… 

    … (print utils from src/print)
    @mrienstra
    mrienstra committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e3140f5 View commit details
    Browse the repository at this point in the history

  5. chore(expect): add all print utils to main expect export (expect.prin… 

    …t) (print utils from src/print)
    @mrienstra
    mrienstra committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    142f85f View commit details
    Browse the repository at this point in the history