New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update documentation for Timer Mocks #11731
Conversation
d09aff6
to
f25caff
Compare
Codecov Report
@@ Coverage Diff @@
## master #11731 +/- ##
=======================================
Coverage 69.04% 69.04%
=======================================
Files 312 312
Lines 16366 16366
Branches 4746 4746
=======================================
Hits 11300 11300
Misses 5039 5039
Partials 27 27 Continue to review full report at Codecov.
|
f25caff
to
24ed2a4
Compare
(sorry, misclicked)
Could you separate those out into another PR so this one can be just the changed text? |
Yep, can do; I just thought it would make sense to keep them here while it's a draft so that it can be previewed together. Since afaik line highlighting or the admonition in question aren't used elsewhere so far. I would suggest that I cherry pick these out when the PR is all tied up and ready. I also noticed today that my F.A.Q. answer is inaccurate; since it's still possible to spy on the global yourself. So I will adjust that and try to think of another way to encourage the point I was trying to make re: decoupling from implementation details |
Use a darker background color for Note style admonitions in dark mode to reduce eye strain.
aebeabf
to
3a1c230
Compare
Lost track of this, sorry @sigveio! I really like these changes, would you be interested in reviving this PR? |
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The Timer Mocks guide in the documentation is currently out of date with examples based on the old legacy timers. Very few of the examples work anymore, and this seems to generate quite a few bug reports and support requests in the issue tracker and across various other channels.
My goal with this PR is to bring it up to date, and also change the structure slightly to drive home some of the more important points early on.
The PR contains some minor tweaks to the website to accommodate this:
Preview
A preview is available here. Feedback is welcome :-)
Todo
Please note that this is a "work in progress"
examples/timer
->examples/timer/legacy
examples/timer/modern
Test plan
n/a
Supersedes #11324, #10964, #10022
Closes #11713