Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore DNSCHANNEL when using --detectOpenHandles #11470

Merged
merged 3 commits into from May 28, 2021
Merged

Ignore DNSCHANNEL when using --detectOpenHandles #11470

merged 3 commits into from May 28, 2021

Commits on May 28, 2021

  1. Ignore DNSCHANNEL when using --detectOpenHandles 

    It turns out that Node.js only holds a weak reference on `DNSCHANNEL` async resources, so they won't prevent a process from exiting. This changes `--detectOpenHandles` to ignore `DNSCHANNEL` handles.

Because Jest dedupes open handles by their stack trace, and async handles indirectly opened from *other* async handles get the same stack trace as the first handle, tracking the `DNSCHANNEL` resource can obscure other, more meaningful handles that were indirectly created and actually *are* causing the process to hang. Fixing this makes it a little easier for users to identify the actual issue that might be causing their tests to hang.

Fixes jestjs#9982.
    @Mr0grog
    Mr0grog committed May 28, 2021
    Copy the full SHA
    44ca80a View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @Mr0grog
    Mr0grog committed May 28, 2021
    Copy the full SHA
    2c1d13e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 9982-dont-track-dnschannel-async-handles

    @SimenB
    SimenB committed May 28, 2021
    Copy the full SHA
    702f040 View commit details
    Browse the repository at this point in the history