Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-config): use requireOrImportModule util function for ESM/CJS import #11206

Merged
merged 1 commit into from Mar 17, 2021
Merged

refactor(jest-config): use requireOrImportModule util function for ESM/CJS import #11206

merged 1 commit into from Mar 17, 2021

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Mar 17, 2021

Summary

Reuse the work from #11199

Test plan

Green CI

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if CI is happy, I'm happy 😀

@ahnpnl ahnpnl marked this pull request as ready for review March 17, 2021 10:06
@codecov-io
Copy link

Codecov Report

Merging #11206 (24ed2a9) into master (990d9b9) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11206      +/-   ##
==========================================
+ Coverage   64.26%   64.30%   +0.04%     
==========================================
  Files         309      309              
  Lines       13495    13485      -10     
  Branches     3289     3286       -3     
==========================================
  Hits         8672     8672              
+ Misses       4114     4104      -10     
  Partials      709      709              
Impacted Files Coverage Δ
packages/jest-config/src/normalize.ts 77.95% <50.00%> (+1.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990d9b9...24ed2a9. Read the comment docs.

@SimenB SimenB merged commit ce58a0d into jestjs:master Mar 17, 2021
@ahnpnl ahnpnl deleted the use-util-import branch March 19, 2021 15:05
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants