Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(snapshot): inline snapshots can be used without prettier #11129

Merged
merged 1 commit into from May 7, 2021

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Feb 28, 2021

Prettier is no longer required since #7792 landed.
IMO the docs could now present toMatchInlineSnapshot more prominently and toMatchSnapshot only as a side note, but that's for another time.

@jeysal jeysal force-pushed the inline-snap-no-prettier-docs branch from 01c17f8 to 7ae8038 Compare February 28, 2021 16:36
@jeysal jeysal requested a review from SimenB February 28, 2021 16:36
@jeysal jeysal added this to the Jest 27 milestone Feb 28, 2021
@SimenB
Copy link
Member

SimenB commented May 7, 2021

@jeysal sorry, missed this. Could you rebase now we've got docusarus 2?

@jeysal jeysal force-pushed the inline-snap-no-prettier-docs branch from 7ae8038 to 443ec9b Compare May 7, 2021 10:13
@jeysal
Copy link
Contributor Author

jeysal commented May 7, 2021

done :)

@SimenB SimenB merged commit a2f1700 into jestjs:master May 7, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants