fix: don't mutate the sample in expect.objectContaining() #10711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeysal
approved these changes
Oct 26, 2020
SimenB
approved these changes
Oct 26, 2020
SimenB
added a commit
to SimenB/jest
that referenced
this pull request
Nov 2, 2020
…stjs#10711)" This reverts commit f84a807.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10689. PR #10508 replaced the sample's properties with asymmetric matchers to facilitate recursion. This PR instead constructs asymmetric matchers each time the base matcher is invoked, avoiding the need to mutate the sample.
Test plan
Added a test case asserting that the sample is not mutated.