Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert watch mode change for onlyFailures mode #10692

Merged
merged 2 commits into from Oct 26, 2020
Merged

fix: revert watch mode change for onlyFailures mode #10692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76d87d1
revert normalize.ts
victorphoenix3 Oct 24, 2020
b5e342a
Merge branch 'master' into edit
SimenB Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@

### Fixes

- `[jest-config]` Fix bug introduced in watch mode by PR[#10678](https://github.com/facebook/jest/pull/10678/files#r511037803) ([#10692](https://github.com/facebook/jest/pull/10692))
- `[expect]` Stop modifying the sample in `expect.objectContaining()` ([#10711](https://github.com/facebook/jest/pull/10711))

### Chore & Maintenance
Expand Down
3 changes: 1 addition & 2 deletions packages/jest-config/src/normalize.ts
View file
Open in desktop
Expand Up @@ -989,9 +989,8 @@ export default function normalize(
newOptions.onlyFailures = false;
} else if (newOptions.testPathPattern) {
// When passing a test path pattern we don't want to only monitor changed
// or failed files unless `--watch` is also passed.
// files unless `--watch` is also passed.
newOptions.onlyChanged = newOptions.watch;
newOptions.onlyFailures = newOptions.watch;
}

if (!newOptions.onlyChanged) {
Expand Down