Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @types/jest to 26.x #10405

Closed
wants to merge 1 commit into from

Conversation

smartclash
Copy link
Contributor

Summary

Upgrades @types/jest inside package.json to v26.0.9. This had to be done because we are working on integrating typings tests into jest.

Upgrading types makes sure that we run our tests against the proper version and not something else.

Ref: MLH-Fellowship#4

Test plan

None

@smartclash
Copy link
Contributor Author

Just saw the comment made by @SimenB on #10399 (comment). So does that mean upgrading to v26 would be a bad idea?

@SimenB
Copy link
Member

SimenB commented Aug 14, 2020

Discussed on Discord (let's track it in #10399)

@SimenB SimenB closed this Aug 14, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants