Add helpful error message to TimerMocks #10184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help the reader to understand the context in which `jest.runOnlyPendingTimers()` is useful, by refering to the error that gets thrown when the timers are in an endless loop.
SimenB
reviewed
Jun 23, 2020
|
|
||
| For these, running all the timers would be an endless loop, throwing the following error: | ||
|
|
||
| ```Ran 100000 timers, and there are still more! Assuming we've hit an infinite recursion and bailing out...``` |
There was a problem hiding this comment.
could you run prettier on this file?
|
Landed in #12248 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Help the reader to understand the context in which
jest.runOnlyPendingTimers()is useful, by referring to the error that gets thrown when the timers are in an endless loop.