fix: support .toHaveProperty('') (#12251)

jestjs · Jan 28, 2022 · d1bc333 · d1bc333
1 parent 056e5ef
commit d1bc333
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- `[expect]` Add a fix for `.toHaveProperty('')` ([#12251](https://github.com/facebook/jest/pull/12251))
 - `[jest-environment-node]` Add `atob` and `btoa` ([#12269](https://github.com/facebook/jest/pull/12269))
 
 ### Chore & Maintenance

diff --git a/packages/expect/src/__tests__/matchers.test.js b/packages/expect/src/__tests__/matchers.test.js
@@ -1898,6 +1898,7 @@ describe('.toHaveProperty()', () => {
     [new E('div'), 'nodeType', 1],
     ['', 'length', 0],
     [memoized, 'memo', []],
+    [{'': 1}, '', 1],
   ].forEach(([obj, keyPath, value]) => {
     test(`{pass: true} expect(${stringify(
       obj,

diff --git a/packages/expect/src/utils.ts b/packages/expect/src/utils.ts
@@ -373,9 +373,15 @@ export const partition = <T>(
 };
 
 export const pathAsArray = (propertyPath: string): Array<any> => {
+  const properties: Array<string> = [];
+
+  if (propertyPath === '') {
+    properties.push('');
+    return properties;
+  }
+
   // will match everything that's not a dot or a bracket, and "" for consecutive dots.
   const pattern = RegExp('[^.[\\]]+|(?=(?:\\.)(?:\\.|$))', 'g');
-  const properties: Array<string> = [];
 
   // Because the regex won't match a dot in the beginning of the path, if present.
   if (propertyPath[0] === '.') {