only move if not allowed access already

jestjs · Nov 1, 2020 · c09dcc7 · c09dcc7
1 parent ca10a39
commit c09dcc7
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/packages/babel-plugin-jest-hoist/src/index.ts b/packages/babel-plugin-jest-hoist/src/index.ts
@@ -133,27 +133,27 @@ FUNCTIONS.mock = args => {
       }
 
       if (!found) {
-        const binding = scope.bindings[name];
+        let isAllowedIdentifier =
+          (scope.hasGlobal(name) && ALLOWED_IDENTIFIERS.has(name)) ||
+          /^mock/i.test(name) ||
+          // Allow istanbul's coverage variable to pass.
+          /^(?:__)?cov/.test(name);
 
-        if (binding) {
-          // @ts-expect-error `init` does not exist
-          const initNode = binding.path.node.init;
+        if (!isAllowedIdentifier) {
+          const binding = scope.bindings[name];
+
+          if (binding) {
+            // @ts-expect-error `init` does not exist
+            const initNode = binding.path.node.init;
 
-          if (binding.constant && scope.isPure(initNode, true)) {
-            // replace the reference with its constant value
-            id.replaceWith(initNode);
+            if (binding.constant && scope.isPure(initNode, true)) {
+              // replace the reference with its constant value
+              id.replaceWith(initNode);
 
-            found = true;
+              isAllowedIdentifier = true;
+            }
           }
         }
-      }
-
-      if (!found) {
-        const isAllowedIdentifier =
-          (scope.hasGlobal(name) && ALLOWED_IDENTIFIERS.has(name)) ||
-          /^mock/i.test(name) ||
-          // Allow istanbul's coverage variable to pass.
-          /^(?:__)?cov/.test(name);
 
         if (!isAllowedIdentifier) {
           throw id.buildCodeFrameError(