Skip to content

Commit

Permalink
feat: Flush animation frames every 16ms when using legacy timers (#11567
Browse files Browse the repository at this point in the history
)
  • Loading branch information
eps1lon committed Jun 14, 2021
1 parent d1882f2 commit aeb1ab5
Show file tree
Hide file tree
Showing 7 changed files with 386 additions and 21 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,8 @@

### Features

- `[jest-fake-timers]` Flush callbacks scheduled with `requestAnimationFrame` every 16ms when using legacy timers. ([#11523](https://github.com/facebook/jest/pull/11567))

### Fixes

- `[jest-reporter]` Allow `node-notifier@10` as peer dependency ([#11523](https://github.com/facebook/jest/pull/11523))
Expand Down
26 changes: 26 additions & 0 deletions e2e/fake-time/legacy/requestAnimationFrame/__tests__/test.js
@@ -0,0 +1,26 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

/* global requestAnimationFrame */

'use strict';

test('requestAnimationFrame', () => {
jest.useFakeTimers('legacy');
let frameTimestamp = -1;
requestAnimationFrame(timestamp => {
frameTimestamp = timestamp;
});

jest.advanceTimersByTime(15);

expect(frameTimestamp).toBe(-1);

jest.advanceTimersByTime(1);

expect(frameTimestamp).toBeGreaterThan(15);
});
5 changes: 5 additions & 0 deletions e2e/fake-time/legacy/requestAnimationFrame/package.json
@@ -0,0 +1,5 @@
{
"jest": {
"testEnvironment": "jsdom"
}
}
26 changes: 26 additions & 0 deletions e2e/fake-time/modern/requestAnimationFrame/__tests__/test.js
@@ -0,0 +1,26 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

/* global requestAnimationFrame */

'use strict';

test('requestAnimationFrame', () => {
jest.useFakeTimers('modern');
let frameTimestamp = -1;
requestAnimationFrame(timestamp => {
frameTimestamp = timestamp;
});

jest.advanceTimersByTime(15);

expect(frameTimestamp).toBe(-1);

jest.advanceTimersByTime(1);

expect(frameTimestamp).toBeGreaterThan(15);
});
5 changes: 5 additions & 0 deletions e2e/fake-time/modern/requestAnimationFrame/package.json
@@ -0,0 +1,5 @@
{
"jest": {
"testEnvironment": "jsdom"
}
}

0 comments on commit aeb1ab5

Please sign in to comment.