Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eslint-config-airbnb #78

Closed
wants to merge 6 commits into from
Closed

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 10, 2019

Gets rid of peer dependency warning when running yarn. Also bumps set-value and handlebars for vulnerability fixes

@SimenB
Copy link
Member Author

SimenB commented Oct 10, 2019

hmm, some ugly config option error with eslint 4. ideas on the cleanest way to deal with it? override the config for the rule?

    /home/travis/build/jest-community/jest-runner-eslint/node_modules/eslint-config-airbnb-base/rules/style.js:
    	Configuration for rule "camelcase" is invalid:
    	Value {"properties":"never","ignoreDestructuring":false} should NOT have additional properties.
    Referenced from: /home/travis/build/jest-community/jest-runner-eslint/node_modules/eslint-config-airbnb-base/index.js
    Referenced from: /home/travis/build/jest-community/jest-runner-eslint/.eslintrc.json
      at validateRuleOptions (node_modules/eslint/lib/config/config-validator.js:119:19)
          at Array.forEach (<anonymous>)
          at Array.reduceRight (<anonymous>)

@ljharb
Copy link
Collaborator

ljharb commented Oct 10, 2019

We’ll have to install the older version of the airbnb config that supports eslint 4, when testing eslint 4 - ie, npm ls must pass before tests can be meaningful.

@SimenB
Copy link
Member Author

SimenB commented Oct 10, 2019

Makes sense, thanks!

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2020

This should be easier to do properly now thanks to the work of @grxy over in #83. If anyone feels up for it 😀

@SimenB SimenB mentioned this pull request May 27, 2020
12 tasks
@MichaelDeBoey
Copy link
Contributor

Closed by #92

@SimenB
Copy link
Member Author

SimenB commented Jul 4, 2020

🎉

@SimenB SimenB closed this Jul 4, 2020
@SimenB SimenB deleted the bump-eslint-config-airbnb branch July 4, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants