Don't assume test execution failure if testExecError is null #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 24, 2022
Co-authored-by: Jordan Harband <ljharb@gmail.com>
|
Thanks for fixing! Sorry for the delay - I had some issues with my Github account that are now resolved. Will comment here when I publish a new release. |
|
14.0.1 is now published containing this fix. Thanks again! |
renovate bot
added a commit
to apollographql/apollo-server
that referenced
this pull request
Aug 26, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@graphql-codegen/cli](https://togithub.com/dotansimha/graphql-code-generator) | [`2.11.7` -> `2.11.8`](https://renovatebot.com/diffs/npm/@graphql-codegen%2fcli/2.11.7/2.11.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [cspell](https://togithub.com/streetsidesoftware/cspell) | [`6.8.0` -> `6.8.1`](https://renovatebot.com/diffs/npm/cspell/6.8.0/6.8.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [jest-junit](https://togithub.com/jest-community/jest-junit) | [`14.0.0` -> `14.0.1`](https://renovatebot.com/diffs/npm/jest-junit/14.0.0/14.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotansimha/graphql-code-generator</summary> ### [`v2.11.8`](https://togithub.com/dotansimha/graphql-code-generator/blob/HEAD/packages/graphql-codegen-cli/CHANGELOG.md#​2118) [Compare Source](https://togithub.com/dotansimha/graphql-code-generator/compare/@graphql-codegen/cli@2.11.7...@graphql-codegen/cli@2.11.8) ##### Patch Changes - [#​8289](https://togithub.com/dotansimha/graphql-code-generator/pull/8289) [`b5897fcad`](https://togithub.com/dotansimha/graphql-code-generator/commit/b5897fcad2832d9ffbed0eb2f59e6b7535f4b61c) Thanks [@​n1ru4l](https://togithub.com/n1ru4l)! - dependencies updates: - Updated dependency [`graphql-config@^4.3.4` ↗︎](https://www.npmjs.com/package/graphql-config/v/null) (from `^4.3.1`, in `dependencies`) - [#​8289](https://togithub.com/dotansimha/graphql-code-generator/pull/8289) [`b5897fcad`](https://togithub.com/dotansimha/graphql-code-generator/commit/b5897fcad2832d9ffbed0eb2f59e6b7535f4b61c) Thanks [@​n1ru4l](https://togithub.com/n1ru4l)! - resolve issue for loading typescript configs </details> <details> <summary>streetsidesoftware/cspell</summary> ### [`v6.8.1`](https://togithub.com/streetsidesoftware/cspell/blob/HEAD/CHANGELOG.md#​681-2022-08-26) [Compare Source](https://togithub.com/streetsidesoftware/cspell/compare/v6.8.0...v6.8.1) **Note:** Version bump only for package cspell-monorepo </details> <details> <summary>jest-community/jest-junit</summary> ### [`v14.0.1`](https://togithub.com/jest-community/jest-junit/releases/tag/v14.0.1) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v14.0.0...v14.0.1) Prevent unnecessary duplicate test cases by [@​azzlack](https://togithub.com/azzlack) - [jest-community/jest-junit#221 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/apollographql/apollo-server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE3Ni4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to apollographql/apollo-server
that referenced
this pull request
Sep 23, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@graphql-tools/mock](https://togithub.com/ardatan/graphql-tools) | [`8.7.3` -> `8.7.6`](https://renovatebot.com/diffs/npm/@graphql-tools%2fmock/8.7.3/8.7.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@graphql-tools/utils](https://togithub.com/ardatan/graphql-tools) | [`8.10.0` -> `8.12.0`](https://renovatebot.com/diffs/npm/@graphql-tools%2futils/8.10.0/8.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/aws-lambda](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/aws-lambda) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`8.10.102` -> `8.10.104`](https://renovatebot.com/diffs/npm/@types%2faws-lambda/8.10.102/8.10.104) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/express](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/express) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`4.17.13` -> `4.17.14`](https://renovatebot.com/diffs/npm/@types%2fexpress/4.17.13/4.17.14) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/express-serve-static-core](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/express-serve-static-core) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`4.17.30` -> `4.17.31`](https://renovatebot.com/diffs/npm/@types%2fexpress-serve-static-core/4.17.30/4.17.31) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/lodash](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`4.14.184` -> `4.14.185`](https://renovatebot.com/diffs/npm/@types%2flodash/4.14.184/4.14.185) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`3.29.1` -> `3.29.2`](https://renovatebot.com/diffs/npm/fastify/3.29.1/3.29.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [jest-junit](https://togithub.com/jest-community/jest-junit) | [`14.0.0` -> `14.0.1`](https://renovatebot.com/diffs/npm/jest-junit/14.0.0/14.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [rollup](https://rollupjs.org/) ([source](https://togithub.com/rollup/rollup)) | [`2.78.1` -> `2.79.1`](https://renovatebot.com/diffs/npm/rollup/2.78.1/2.79.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ardatan/graphql-tools (@​graphql-tools/mock)</summary> ### [`v8.7.6`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/mock/CHANGELOG.md#​876) [Compare Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/mock@8.7.5...@graphql-tools/mock@8.7.6) ##### Patch Changes - Updated dependencies \[[`43c736bd`](https://togithub.com/ardatan/graphql-tools/commit/43c736bd1865c00898966a7ed14060496c9e6a0c)]: - [@​graphql-tools/utils](https://togithub.com/graphql-tools/utils)[@​8](https://togithub.com/8).12.0 - [@​graphql-tools/schema](https://togithub.com/graphql-tools/schema)[@​9](https://togithub.com/9).0.4 ### [`v8.7.5`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/mock/CHANGELOG.md#​875) [Compare Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/mock@8.7.4...@graphql-tools/mock@8.7.5) ##### Patch Changes - Updated dependencies \[[`71cb4fae`](https://togithub.com/ardatan/graphql-tools/commit/71cb4faeb0833a228520a7bc2beed8ac7274443f), [`403ed450`](https://togithub.com/ardatan/graphql-tools/commit/403ed4507eff7cd509f410f7542a702da72e1a9a)]: - [@​graphql-tools/utils](https://togithub.com/graphql-tools/utils)[@​8](https://togithub.com/8).11.0 - [@​graphql-tools/schema](https://togithub.com/graphql-tools/schema)[@​9](https://togithub.com/9).0.3 ### [`v8.7.4`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/mock/CHANGELOG.md#​874) [Compare Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/mock@8.7.3...@graphql-tools/mock@8.7.4) ##### Patch Changes - Updated dependencies \[[`4fe3d9c0`](https://togithub.com/ardatan/graphql-tools/commit/4fe3d9c037e9c138bd8a9b04b3977d74eba32c97)]: - [@​graphql-tools/utils](https://togithub.com/graphql-tools/utils)[@​8](https://togithub.com/8).10.1 - [@​graphql-tools/schema](https://togithub.com/graphql-tools/schema)[@​9](https://togithub.com/9).0.2 </details> <details> <summary>ardatan/graphql-tools (@​graphql-tools/utils)</summary> ### [`v8.12.0`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/utils/CHANGELOG.md#​8120) [Compare Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/utils@8.11.0...@graphql-tools/utils@8.12.0) ##### Minor Changes - [#​4706](https://togithub.com/ardatan/graphql-tools/pull/4706) [`43c736bd`](https://togithub.com/ardatan/graphql-tools/commit/43c736bd1865c00898966a7ed14060496c9e6a0c) Thanks [@​ardatan](https://togithub.com/ardatan)! - Do not throw duplicate type error name while rewiring types ### [`v8.11.0`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/utils/CHANGELOG.md#​8110) [Compare Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/utils@8.10.1...@graphql-tools/utils@8.11.0) ##### Minor Changes - [#​4661](https://togithub.com/ardatan/graphql-tools/pull/4661) [`403ed450`](https://togithub.com/ardatan/graphql-tools/commit/403ed4507eff7cd509f410f7542a702da72e1a9a) Thanks [@​nicolaslt](https://togithub.com/nicolaslt)! - Add getArgumentsWithDirectives ##### Patch Changes - [#​4694](https://togithub.com/ardatan/graphql-tools/pull/4694) [`71cb4fae`](https://togithub.com/ardatan/graphql-tools/commit/71cb4faeb0833a228520a7bc2beed8ac7274443f) Thanks [@​dimatill](https://togithub.com/dimatill)! - Fix pruneSchema to not remove type that is used only as a directive argument type ### [`v8.10.1`](https://togithub.com/ardatan/graphql-tools/blob/HEAD/packages/utils/CHANGELOG.md#​8101) [Compare Source](https://togithub.com/ardatan/graphql-tools/compare/@graphql-tools/utils@8.10.0...@graphql-tools/utils@8.10.1) ##### Patch Changes - [#​4673](https://togithub.com/ardatan/graphql-tools/pull/4673) [`4fe3d9c0`](https://togithub.com/ardatan/graphql-tools/commit/4fe3d9c037e9c138bd8a9b04b3977d74eba32c97) Thanks [@​thgreasi](https://togithub.com/thgreasi)! - Fix typings for TypeScript 4.8 </details> <details> <summary>fastify/fastify</summary> ### [`v3.29.2`](https://togithub.com/fastify/fastify/releases/tag/v3.29.2) [Compare Source](https://togithub.com/fastify/fastify/compare/v3.29.1...v3.29.2) ##### What's Changed - fix: backport reused connection fix by [@​salzhrani](https://togithub.com/salzhrani) in [fastify/fastify#4217 ##### New Contributors - [@​salzhrani](https://togithub.com/salzhrani) made their first contribution in [fastify/fastify#4217 **Full Changelog**: fastify/fastify@v3.29.1...v3.29.2 </details> <details> <summary>jest-community/jest-junit</summary> ### [`v14.0.1`](https://togithub.com/jest-community/jest-junit/releases/tag/v14.0.1) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v14.0.0...v14.0.1) Prevent unnecessary duplicate test cases by [@​azzlack](https://togithub.com/azzlack) - [jest-community/jest-junit#221 </details> <details> <summary>rollup/rollup</summary> ### [`v2.79.1`](https://togithub.com/rollup/rollup/blob/HEAD/CHANGELOG.md#​2791) [Compare Source](https://togithub.com/rollup/rollup/compare/v2.79.0...v2.79.1) *2022-09-22* ##### Bug Fixes - Avoid massive performance degradation when creating thousands of chunks ([#​4643](https://togithub.com/rollup/rollup/issues/4643)) ##### Pull Requests - [#​4639](https://togithub.com/rollup/rollup/pull/4639): fix: typo docs and contributors link in CONTRIBUTING.md ([@​takurinton](https://togithub.com/takurinton)) - [#​4641](https://togithub.com/rollup/rollup/pull/4641): Update type definition of resolveId ([@​ivanjonas](https://togithub.com/ivanjonas)) - [#​4643](https://togithub.com/rollup/rollup/pull/4643): Improve performance of chunk naming collision check ([@​lukastaegert](https://togithub.com/lukastaegert)) ### [`v2.79.0`](https://togithub.com/rollup/rollup/blob/HEAD/CHANGELOG.md#​2790) [Compare Source](https://togithub.com/rollup/rollup/compare/v2.78.1...v2.79.0) *2022-08-31* ##### Features - Add `amd.forceJsExtensionForImports` to enforce using `.js` extensions for relative AMD imports ([#​4607](https://togithub.com/rollup/rollup/issues/4607)) ##### Pull Requests - [#​4607](https://togithub.com/rollup/rollup/pull/4607): add option to keep extensions for amd ([@​wh1tevs](https://togithub.com/wh1tevs)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/apollographql/apollo-server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwMS4zIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #220.
Currently, jest-junit assumes that any value other than
undefinedfortestExecErroris an error.However, this property can also be
nullwithout there being an actual problem.This PR adds an additional check for
null, and tests to validate it.