Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to GH Actions #185

Merged
merged 5 commits into from Sep 29, 2021
Merged

chore: migrate to GH Actions #185

merged 5 commits into from Sep 29, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 29, 2021

Travis is dead for open source, so this migrates CI to GH Actions.

Changes from Travis run

  • Runs just yarn test as we install the version of Jest we wanna test against in the action itself
  • Runs tests on node 16 in addition to the existent ones
  • Runs tests against Jest 27 in addition to the existent ones pulled out as tests uses jasmine globals - will send separate PR for 27 (also adding it to peer deps): chore: use Jest 27 #186
  • Runs tests on Windows and Mac - tests fails on windows due to slashes, I'll send a separate PR fixing that: chore: run tests on Windows #187
  • Caches deps

@SimenB SimenB mentioned this pull request Sep 29, 2021
strategy:
fail-fast: false
matrix:
node-version: [10.x, 12.x, 13.x, 14.x, 16.x]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 is EOL, but since it was tested on travis let's keep it

(10 is EOL as well, but that's documented in README as minimum version)

@SimenB
Copy link
Member Author

SimenB commented Sep 29, 2021

@palmerj3 I'll land this as it's better than no CI 🙂 Of course feel free to change anything you want in it

@SimenB SimenB merged commit 77e5b64 into master Sep 29, 2021
@SimenB SimenB deleted the gh-actions branch September 29, 2021 09:54
@palmerj3
Copy link
Collaborator

Thanks @SimenB ! Been meaning to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants