Fix displayName usage in templates #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @palmerj3 |
|
Thank you! |
|
@palmerj3 would it be possible to get a minor/patch version bump published? I was hoping to use this as soon as it's available :) |
|
Yeah sorry I tried right after it was merged and github wasn't letting me create a release. I'll try again. |
|
@D4N14L ok this is now published in 12.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the
displayNamefield was changed in Jest 24.x (see: displayName) to always return an object of the format:The current implementation leads to the
displayNametemplate printing as[object Object]instead of the actual displayName value. This change fixes this by switching usage based on the property type.