Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playground file name #648

Merged
merged 1 commit into from Sep 19, 2023

Conversation

9at8
Copy link
Contributor

@9at8 9at8 commented Sep 7, 2023

Fix playground file name

image

The testfile component automatically adds ".test.js" suffix

[`/${props.name}.test.js`]: props.children,

What

playground.test.js.test.js -> playground.test.js

Why

Looks bad

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: 5bf7a89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@9at8
Copy link
Contributor Author

9at8 commented Sep 14, 2023

friendly ping @mattphillips 😅

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (61df485) 100.00% compared to head (5bf7a89) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #648   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines          674       674           
  Branches       290       290           
=========================================
  Hits           674       674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keeganwitt keeganwitt merged commit d9bb3e3 into jest-community:main Sep 19, 2023
23 checks passed
@keeganwitt
Copy link
Collaborator

@SimenB It looks like this fixed this issue. How is this deployed to the live website? It doesn't look like it's through a changeset (unless I've misunderstood).

@SimenB
Copy link
Member

SimenB commented Sep 20, 2023

@keeganwitt I think the website autodeploys. @mattphillips set it up, so I'm not sure 😅

https://github.com/jest-community/jest-extended/deployments/Production

@mattphillips
Copy link
Member

Annoyingly the site is hosted on Vercel and when I contacted them about making it an open source project/organisation (whatever they call it) so that anyone from the org can deploy, I never heard back 😢

I can re-trigger the deployment as me which should work but yeah need to contact Vercel again or switch to another provider that supports free open source orgs (suggestions welcome).

When I'm next at the keyboard I'll deploy this.

@SimenB
Copy link
Member

SimenB commented Sep 20, 2023

Netlify works for the Jest site fwiw

@mattphillips
Copy link
Member

Maybe I can swap to Netlify instead.

In fact, this reminds me, I was thinking now that we have the Jestjs org on GitHub maybe we should move the community projects there? We could also move this site to a subdomain on jestjs.io domain? Something like jest-extended.jestjs.io

@keeganwitt
Copy link
Collaborator

It'd take a bit of work, but it's a static site, right? GitHub Pages would be another option. I deploy Maven site that way for another project.

@9at8 9at8 deleted the fix-playground-file-name branch September 21, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants