-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exported type, resolve "is not a module" error in ts #559
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 674 673 -1
Branches 290 289 -1
=========================================
- Hits 674 673 -1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0d6255d
to
57adf6d
Compare
Hey @SimenB is there anything I can do to get some eyes on this? :) |
@keeganwitt sorry to bother, would it be possible to have this looked at by yourself or a member of the team? |
84b2f16
to
ba34065
Compare
I'm not sure if there's anything else we need in the module you added. But this does seem to fix the issue. Thank you! |
Thanks @keeganwitt , really appreciate it! :) |
Any chance this change could be released soon? It would be handy. |
We are working on a release now (#605). |
What
Update the interface for matches to extend a record to provide the index string signature expected by
expect.extend
, matches what the@testing-library
types do: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/testing-library__jest-dom/matchers.d.ts#L1Why
Fixes the error:
Issue #367 was closed without addressing this problem, instead, the PR made that was used to close the issue describes a workaround. This workaround is not so suitable for other test suites consuming these matchers, like vitest without globals.
Fixes #367
Currently, this documentation errors with typescript, this fixes it and improves support.
Notes
Housekeeping