Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toIncludeAllMembersInOrder. #512

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add toIncludeAllMembersInOrder. #512

wants to merge 8 commits into from

Conversation

sandinmyjoints
Copy link

@sandinmyjoints sandinmyjoints commented Sep 21, 2022 •
edited

What

Adding toIncludeAllMembersInOrder.

Why

Fixes #231

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@sandinmyjoints sandinmyjoints force-pushed the feature-toIncludeAllMembersInOrder branch from 46744ae to a90eb92 Compare September 21, 2022 21:10
@sandinmyjoints sandinmyjoints force-pushed the feature-toIncludeAllMembersInOrder branch from a90eb92 to b26c9fe Compare September 21, 2022 21:11
@sandinmyjoints sandinmyjoints force-pushed the feature-toIncludeAllMembersInOrder branch from 1bc73b7 to d5b07db Compare September 21, 2022 21:26
@sandinmyjoints sandinmyjoints force-pushed the feature-toIncludeAllMembersInOrder branch from d5b07db to d8044cd Compare September 21, 2022 21:26
@sandinmyjoints
Copy link
Author

I'm a first-time contributor, bumping for someone to approve workflow.

@beeryt beeryt mentioned this pull request Oct 26, 2022
Closed
@SimenB
Copy link
Member

SimenB commented Feb 18, 2023

@sandinmyjoints could you resolve the conflict?

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023 •
edited

⚠️ No Changeset found

Latest commit: dec509f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited

Codecov Report

Merging #512 (768f875) into main (61bd5bf) will decrease coverage by 0.15%.
The diff coverage is 95.23%.

❗ Current head 768f875 differs from pull request most recent head dec509f. Consider uploading reports for the commit dec509f to get more accurate results

@@             Coverage Diff             @@
##              main     #512      +/-   ##
===========================================
- Coverage   100.00%   99.85%   -0.15%     
===========================================
  Files           73       74       +1     
  Lines          674      695      +21     
  Branches       290      298       +8     
===========================================
+ Hits           674      694      +20     
- Misses           0        1       +1
Impacted Files Coverage Δ
src/matchers/toIncludeAllMembersInOrder.js 95.23% <95.23%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@keeganwitt
Copy link
Collaborator

Merged main to this branch, added a spot missing in the types, and made lint fixes. It's now failing for coverage reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: .toMatchArray()
3 participants
@sandinmyjoints @SimenB @keeganwitt